[RFC] Introduce custom BadgeStyle #7007
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
badgeColor
branch
from
481c081 to
423ef1f
Compare
VincentLanglet
commented
Jun 21, 2025
| @@ -0,0 +1,48 @@ | |||
| <?php | |||
|
|
|||
| namespace EasyCorp\Bundle\EasyAdminBundle\Field\Style; | |||
Contributor
Author
There was a problem hiding this comment.
Not sure in which namespace I should declare this class
VincentLanglet
force-pushed
the
badgeColor
branch
from
2d629c9 to
581a282
Compare
VincentLanglet
changed the title
VincentLanglet
force-pushed
the
badgeColor
branch
from
e2ee3bd to
38e3325
Compare
VincentLanglet
force-pushed
the
badgeColor
branch
from
38e3325 to
fe583a5
Compare
VincentLanglet
commented
Jun 22, 2025
| return new self(['badge'], []); | ||
| } | ||
|
|
||
| public function withBgColor(string $backgroundColor, bool $autoTextContrast = true): self |
Contributor
Author
There was a problem hiding this comment.
Not sure if
- we should disable
autoTextContrastby default - we shouldn't provide such option and let the user decide (but it require to have public addClass method
VincentLanglet
force-pushed
the
badgeColor
branch
from
01d382f to
3d0c582
Compare
Contributor
Author
|
Do you mind taking a look @javiereguiluz ? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WDYT @javiereguiluz ? :)